Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why synthetic receipts don't mark the room as read #3715

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Sep 7, 2023


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added this pull request to the merge queue Sep 7, 2023
richvdh
richvdh previously requested changes Sep 7, 2023
src/models/room.ts Outdated Show resolved Hide resolved
@andybalaam andybalaam removed this pull request from the merge queue due to a manual request Sep 7, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh
Copy link
Member

richvdh commented Sep 7, 2023

This is a followup to #3706, for the record

@andybalaam andybalaam requested review from richvdh and removed request for richvdh September 7, 2023 15:29
@andybalaam andybalaam added this pull request to the merge queue Sep 7, 2023
Merged via the queue into develop with commit 5d4334b Sep 7, 2023
20 checks passed
@andybalaam andybalaam deleted the andybalaam/comment-about-not-synthetic-receipts branch September 7, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants